detect clang/gcc using --version #709
Conversation
|
@thomcc This patch is broken after rebase. Could you tell me if it is worth to fix it or not? |
| @@ -1663,6 +1663,16 @@ impl Build { | |||
| family.add_force_frame_pointer(cmd); | |||
| } | |||
|
|
|||
| if !cmd.is_like_msvc() { | |||
There was a problem hiding this comment.
I don't remember the details anymore, but they are related to tests gnu_i686 and gnu_x86_64
There was a problem hiding this comment.
Ah, I got the idea. This happened because gcc() now target x86_64-apple-darwin on macOS.
I can revert this part and add target to gnu_i686 and gnu_x86_64. Is this better?
There was a problem hiding this comment.
By itself it's a formally wrong move. While the -m32/m64 are accepted by clang, the --target argument [which is always passed to clang by cc-rs] describes the intention sufficiently and more importantly more adequately. In other words the options in question should have remained in the ToolFamily::Gnu section. If they cause problems in the section in question, then it would have been more appropriate to solve it there.
On a tangential note. The powepc64 gcc defaults to -m64, so that it's actually more interesting to pass -m32 than -m64. But of course making it symmetric would be better, i.e. pass -m32 if the target is 32-bit ppc, and -m64 otherwise...
youknowone
force-pushed
the
detect-clang
branch
from
1c12087
to
f51788d
Compare
Co-authored-by: Thom Chiovoloni <[email protected]>
youknowone
force-pushed
the
detect-clang
branch
from
f51788d
to
cd3695a
Compare
|
@thomcc Tests are fixed. Could you review it again? |
|
Maybe replacement of #407 |
|
It looks like this broke CI, hmmm... |
This is useful on macos because
gccandccis actuallyclang.gccandccwere regarded asclangeven when it was gcc.m32andm64is not necessary for clang, but also harmless.Do you want to do it as now or want to revert it and change tests run only for gcc?